Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/ve better passport #21

Merged
merged 5 commits into from
Oct 14, 2024
Merged

Feat/ve better passport #21

merged 5 commits into from
Oct 14, 2024

Conversation

Agilulfo1820
Copy link
Member

  • Added VeBetter Passport contract
  • Upgraded X2EarnRewardsPool contract to register actions inside VeBetter Passport
  • Upgraded B3TRGovernor and XAllocationVoting to check isPersion from VeBetter Passport when casting vote
  • Added upgrades changelog

@Agilulfo1820 Agilulfo1820 requested a review from a team as a code owner October 12, 2024 13:05
@socket-security Socket Security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None +1 299 kB ctalkington
npm/[email protected] filesystem +1 851 kB ctalkington
npm/[email protected] None 0 41 kB kasperisager
npm/[email protected] None 0 20.2 kB kasperisager
npm/[email protected] None 0 16.8 kB kibertoad
npm/[email protected] None 0 35.7 kB ctalkington
npm/[email protected] None 0 6.6 kB ctalkington
npm/[email protected] None 0 5.07 kB mafintosh
npm/[email protected] None +3 66.5 kB jpommerening
npm/[email protected] None 0 3.03 kB mafintosh
npm/[email protected] filesystem +1 34.9 kB yqnn
npm/[email protected] None 0 50.8 kB mafintosh
npm/[email protected] filesystem 0 32 kB mafintosh
npm/[email protected] None 0 17.4 kB kasperisager
npm/[email protected] None 0 9.14 kB ctalkington

View full report↗︎

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 57.45731% with 1121 lines in your changes missing coverage. Please review.

Project coverage is 65.44%. Comparing base (0dda53c) to head (d9d7ad7).

Files with missing lines Patch % Lines
contracts/deprecated/V3/B3TRGovernorV3.sol 26.29% 185 Missing ⚠️
contracts/deprecated/V2/X2EarnRewardsPoolV2.sol 14.90% 137 Missing ⚠️
contracts/mocks/VechainNodes/ThunderFactory.sol 7.25% 115 Missing ⚠️
...3/governance/libraries/GovernorProposalLogicV3.sol 53.28% 71 Missing ⚠️
...tracts/mocks/VechainNodes/auction/ClockAuction.sol 7.57% 61 Missing ⚠️
contracts/mocks/VechainNodes/XOwnership.sol 4.83% 59 Missing ⚠️
contracts/mocks/VechainNodes/TokenAuction.sol 10.41% 43 Missing ⚠️
...ts/mocks/VechainNodes/auction/ClockAuctionBase.sol 0.00% 38 Missing ⚠️
...rnance/modules/RoundVotesCountingUpgradeableV1.sol 53.42% 34 Missing ⚠️
contracts/mocks/VechainNodes/utility/SafeMath.sol 0.00% 30 Missing ⚠️
... and 31 more
Additional details and impacted files 
@@             Coverage Diff             @@
##             main      #21       +/-   ##
===========================================
+ Coverage   20.71%   65.44%   +44.73%     
===========================================
  Files          53       99       +46     
  Lines        3911     6534     +2623     
  Branches      574     1289      +715     
===========================================
+ Hits          810     4276     +3466     
+ Misses       3101     2257      -844     
- Partials        0        1        +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roisindowling roisindowling merged commit 6c1ff85 into main Oct 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roisindowling roisindowling roisindowling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Agilulfo1820 @codecov-commenter @roisindowling